WIP: force fastboot environment to be set to test unless specified#272
Open
jkeen wants to merge 1 commit intoembermap:masterfrom
Open
WIP: force fastboot environment to be set to test unless specified#272jkeen wants to merge 1 commit intoembermap:masterfrom
jkeen wants to merge 1 commit intoembermap:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @ryanto
Didn't want to let this stagnate and disappear, but I'm looking for some feedback/collab on this change we were talking about in #32
This seems to work as intended, the problem is testing it. I don't think the user-overrideable setting is 100% necessary, but without it I'm not sure how to test this.
The test I added for this works, but for some strange reason there's another test failure that I couldn't track down last I worked on this. So I thought I'd let this sit publicly on the off chance that someone wants to take a crack at it before I can get to it again